cannot reopen file (Ax.AcadDocument) in pytest

[gswifort]

DOIT executes without any problem, DOIT_PYTEST reports Windows fatal exception: access violation

from pathlib import Path
import pytest
from pyrx import Ax, command

doc_path = Path(__file__).parent / "Drawing1.dwg"

def test_1():
    doc = Ax.AcadApplication().documents().open(str(doc_path), True)
    doc.close()
    doc = Ax.AcadApplication().documents().open(str(doc_path), False)
    doc.close()

@command
def doit():
    test_1()

@command
def doit_pytest():
    pytest.main([__file__])

[gswifort]

It works with the SESSION flag. Is this intentional?

@command(flags=Ap.CmdFlags.SESSION)
def doit_pytest():
    pytest.main([__file__])

[gswifort]

faulthandler.enable() results in an error being reported also in DOIT

@command
def doit5():
    import faulthandler
    faulthandler.enable()

    test_1()

maybe it's worth adding an option to enable faulthandler

[system]
optimization_level = 0
faulthandler = true

[user]
disable_onload = false

[CEXT-Dan]

I don’t know what I’m looking at or what this does, how will users benefit from this flag?

Traceback (most recent call last):
  File "M:\Dev\Projects\PyRxGit\PySamples\_doit.py", line 26, in doit5
    faulthandler.enable()
AttributeError: 'stderr' object has no attribute 'fileno'

[CEXT-Dan]

seems I need to handle fileno in eStderr?

[gswifort]

I don’t know what I’m looking at or what this does

I don't know exactly, but it allows you to detect errors that are normally ignored.

how will users benefit from this flag?

For the user, probably none at all. Primarily for the developer, but there are probably better places for this - e.g. pyrx_onload.py

seems I need to handle fileno in eStderr?

Usually when I work with PyRx I have the console running - that's why I didn't notice this problem.

[CEXT-Dan]

seems I needed to add some attributes to eStdout and eStderr, now doit5 and doit_pytest work in autocad

Success module _DOIT is loaded:
Command: DOIT_PYTEST
M:\Dev\Projects\PyRxGit\PySamples\Drawing1.dwg
============================= test session starts =============================
platform win32 -- Python 3.12.10, pytest-9.0.3, pluggy-1.6.0
rootdir: M:\Dev\Projects\PyRxGit
configfile: pyproject.toml
collected 1 item
_doit.py
.
                                                               [100%]
============================== warnings summary ===============================
c:\users\dan\appdata\local\programs\python\python312\Lib\site-packages\_pytest\config\__init__.py:1310
  c:\users\dan\appdata\local\programs\python\python312\Lib\site-packages\_pytest\config\__init__.py:1310: PytestConfigWarning: assertions not in test modules or plugins will be ignored because assert statements are not executed by the underlying Python interpreter (are you using python -O?)
    self._warn_about_missing_assertion(mode)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================== 1 passed, 1 warning in 1.27s =========================
Command: DOIT_PYTEST
M:\Dev\Projects\PyRxGit\PySamples\Drawing1.dwg
============================= test session starts =============================
platform win32 -- Python 3.12.10, pytest-9.0.3, pluggy-1.6.0
rootdir: M:\Dev\Projects\PyRxGit
configfile: pyproject.toml
collected 1 item
_doit.py
.
                                                               [100%]
============================== warnings summary ===============================
c:\users\dan\appdata\local\programs\python\python312\Lib\site-packages\_pytest\config\__init__.py:1310
  c:\users\dan\appdata\local\programs\python\python312\Lib\site-packages\_pytest\config\__init__.py:1310: PytestConfigWarning: assertions not in test modules or plugins will be ignored because assert statements are not executed by the underlying Python interpreter (are you using python -O?)
    self._warn_about_missing_assertion(mode)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================== 1 passed, 1 warning in 1.14s =========================

[CEXT-Dan]

I didn't receive any Windows fatal exception: access violation yet

[CEXT-Dan]

In general, it’s always safer to use session when working with multiple documents. All Ax functions have a document lock

[CEXT-Dan]

I will make a refresh build with #532 so you can test...

[gswifort]

For me, the error doesn't occur in AutoCAD. In ZWCAD, it happens every time.

[CEXT-Dan]

I tested with ZwCAD 2027 beta, no error, I'll try the other versions later. it could also be the test drawing recomputing something on open, mine just has a couple of lines

[gswifort]

my drawing is empty

[gswifort]

This also causes Windows fatal exception: access violation, an error occurs when closing the document.

tested on zwcad 2025 and 2027

from __future__ import annotations

from pathlib import Path

from pyrx import Ap, Ax, command
from pyrx.console import console

doc_path = Path(__file__).parent / "Drawing1.dwg"

def open_doc_by_path(doc_path: Path, read_only: bool = False) -> Ap.Document:
    axdoc = Ax.AcadApplication().documents().open(str(doc_path), read_only)
    doc = doc_for_ax_doc(axdoc)
    return doc

def doc_for_ax_doc(axdoc: Ax.AcadDocument) -> Ap.Document:
    doc_man = Ap.DocManager()
    for doc in doc_man.documents():
        if doc.acadDocument() == axdoc:
            return doc
    raise ValueError(
        f"No Ap.Document found for Ax.AcadDocument with fullName '{axdoc.fullName()}'"
    )

def close_doc_by_path(doc_path: Path):
    doc_man = Ap.DocManager()
    if not doc_man.isApplicationContext():
        raise RuntimeError("close_doc_by_path can only be called from an application context")
    for doc in doc_man.documents():
        if Path(doc.fileName()) == doc_path:
            doc_man.appContextCloseDocument(doc)

def test_1():
    doc_1 = open_doc_by_path(doc_path, read_only=False)
    doc_2 = open_doc_by_path(doc_path, read_only=True)
    close_doc_by_path(doc_path)


@command(flags=Ap.CmdFlags.SESSION)
def doit7():
    test_1()


@command(flags=Ap.CmdFlags.SESSION)
def doit7_pytest():
    import pytest

    with console():
        pytest.main([__file__, "-v", "-s"])
        input("Press Enter to continue...")


@command(flags=Ap.CmdFlags.SESSION)
def doit7_faulthandler():
    import faulthandler

    with console():
        faulthandler.enable()
        test_1()
        input("Press Enter to continue...")

[CEXT-Dan]

what should test_get_docs_by_path be?

[gswifort]

sorry, it should be test_1

[CEXT-Dan]

seems the console is causing Autocad to hang

[gswifort]

did you press Enter?

[CEXT-Dan]

oh, the console was hidden, I ran doit7_faulthandler in both autocad and zwcad 2027, no issue

[CEXT-Dan]

here is the drawing I'm testing with
Drawing1.zip

[CEXT-Dan]

Oh mean this?

[gswifort]

I tested it on your file, restarted the computer - still the same

[CEXT-Dan]

ugh,! I still see it, at least I can see the violation in C++, I need to work on it

[CEXT-Dan]

Exception thrown at 0x00007FF96AE65F7C in ZWCAD.exe: 0xC0000005: Access violation reading location 0x0000000000000000.

I don’t think it’s us, I will try to reproduce this in C++ tomorrow

[CEXT-Dan]

I think it has to do with the behavior or opening the same document twice.
appContextCloseDocument is attempting to close the document twice, since both have the same path.

AutoCAD allows this and is able to track the document state
BricsCAD does not open two documents, at least it does not show in the tabs
ZwCAD opens two documents, then barfs when hitting the second call to appContextCloseDocument.

Interesting is that if I reverse the order, doit7_faulthandler shows no error

for doc in reversed(doc_man.documents()):
        if Path(doc.fileName()) == doc_path:
            doc_man.appContextCloseDocument(doc)

[CEXT-Dan]

C++ test for ref

    // reported https://github.com/CEXT-Dan/PyRx/discussions/531

    static void openDocAppCtx(const AcString& fullpath)
    {
        if (auto es = acDocManager->appContextOpenDocument(fullpath); es != eOk)
            acutPrintf(L"\nError %ls: ", acadErrorStatusText(es));
    }

    static void closeDocAppCtx(const AcString& fullpath)
    {
        using dociter = std::unique_ptr<AcApDocumentIterator>;

        for (dociter iter(acDocManager->newAcApDocumentIterator()); !iter->done(); iter->step())
        {
            auto doc = iter->document();
            if (doc != nullptr)
            {
                if (fullpath.compareNoCase(doc->fileName()) == 0)
                {
                    if (auto es = acDocManager->appContextCloseDocument(doc); es != eOk)
                        acutPrintf(L"\nError %ls: ", acadErrorStatusText(es));
                }
            }
        }
    }

    static void closeDocAppCtxRev(const AcString& fullpath)
    {
        using dociter = std::unique_ptr<AcApDocumentIterator>;
        std::vector<AcApDocument*> docs;
        for (dociter iter(acDocManager->newAcApDocumentIterator()); !iter->done(); iter->step())
            docs.push_back(iter->document());
        std::reverse(docs.begin(), docs.end());
        for (auto doc : docs)
        {
            if (doc != nullptr)
            {
                if (fullpath.compareNoCase(doc->fileName()) == 0)
                {
                    if (auto es = acDocManager->appContextCloseDocument(doc); es != eOk)
                        acutPrintf(L"\nError %ls: ", acadErrorStatusText(es));
                }
            }
        }
    }

    static void AcRxPyApp_idoit1(void) // ACRX_CMD_SESSION
    {
        AcString fullpath = L"M:\\Dev\\Projects\\PyRxGit\\PySamples\\Drawing1.dwg";
        openDocAppCtx(fullpath);
        openDocAppCtx(fullpath);

        int flag = 0;
        acedGetInt(L"\nPress 0 to leave open, 1 to close: ", &flag);
        if (flag)
            closeDocAppCtxRev(fullpath);
    }