[CHERIoT] Generate export table entries for weak function symbols. #164
+37
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resistor
force-pushed
the
weak-export-table
branch
from
00aa056 to
a8eab7e
Compare
resistor
changed the title
resistor
force-pushed
the
weak-export-table
branch
from
a8eab7e to
323572e
Compare
resistor
changed the title
resistor
force-pushed
the
weak-export-table
branch
from
323572e to
6539d69
Compare
These arise in newer libc++'s, where a library is used for explicit instantiations of some std::string methods. These become weakly exported libcall symbols from the library, and still need to be present in the export table. Since they should only ever be materialized in one translation unit, it's OK for the export table entry to be strongly exported while the symbol itself is weakly exported.
resistor
force-pushed
the
weak-export-table
branch
from
6539d69 to
ab6f8a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These arise in newer libc++'s, where a library is used for explicit
instantiations of some std::string methods. These become weakly
exported libcall symbols from the library, and still need to be
present in the export table. Since they should only ever be materialized
in one translation unit, it's OK for the export table entry to be
strongly exported while the symbol itself is weakly exported.