Skip to content

Conversation

@f-allian
Copy link
Collaborator

This pull request primarily focuses on correcting type annotations in several estimator classes and updating development dependencies. The changes improve code clarity and type safety by using the correct syntax for Python type hints.

Type annotation fixes:

  • Standardized the type annotation syntax for effect_modifiers from dict[Type:Type] to dict[Type, Type] in the following files:
    • causal_testing/estimation/abstract_estimator.py (effect_modifiers: dict[str, Any])
    • causal_testing/estimation/abstract_regression_estimator.py (effect_modifiers: dict[Variable, Any])
    • causal_testing/estimation/cubic_spline_estimator.py (effect_modifiers: dict[Variable, Any])
    • causal_testing/estimation/linear_regression_estimator.py (effect_modifiers: dict[Variable, Any])
    • causal_testing/estimation/experimental_estimator.py (adjustment_set and effect_modifiers: dict[str, Any])

Dependency updates:

  • Added tqdm to the dev dependencies in pyproject.toml to support progress bar functionality during development.

@f-allian f-allian requested a review from jmafoster1 October 14, 2025 09:51
@f-allian f-allian self-assigned this Oct 14, 2025
@f-allian f-allian added the enhancement New feature or request label Oct 14, 2025
@github-actions
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 33 0 0.92s
✅ PYTHON pylint 33 0 5.49s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.27%. Comparing base (20aace7) to head (4f7b245).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files          28       28           
  Lines        1584     1584           
=======================================
  Hits         1525     1525           
  Misses         59       59           
Files with missing lines Coverage Δ
causal_testing/estimation/abstract_estimator.py 100.00% <ø> (ø)
...esting/estimation/abstract_regression_estimator.py 95.83% <ø> (ø)
...ausal_testing/estimation/cubic_spline_estimator.py 96.66% <ø> (ø)
...ausal_testing/estimation/experimental_estimator.py 100.00% <ø> (ø)
..._testing/estimation/linear_regression_estimator.py 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed97ad...4f7b245. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@f-allian f-allian changed the title Housekeeping Corrected type hints in estimator classes and add tqdm to dev dependencies Oct 14, 2025
@f-allian f-allian merged commit 8118cc4 into main Oct 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants