Skip to content

Allow rvalue references to be use with add_flag with no assignment #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025
Merged

Allow rvalue references to be use with add_flag with no assignment #1173

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b877fb
feat: allow rvalue references to be use with add_flag
tnixeu Jun 27, 2025
9c341f0
style: pre-commit.ci fixes
pre-commit-ci[bot] Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions include/CLI/App.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,13 +655,15 @@ class App {
Option *add_flag(std::string flag_name) { return _add_flag_internal(flag_name, CLI::callback_t(), std::string{}); }

/// Add flag with description but with no variable assignment or callback
/// takes a constant string, if a variable string is passed that variable will be assigned the results from the
/// flag
/// takes a constant string or a rvalue reference to a string, if a variable string is passed that variable will be
/// assigned the results from the flag
template <typename T,
enable_if_t<std::is_const<T>::value && std::is_constructible<std::string, T>::value, detail::enabler> =
detail::dummy>
Option *add_flag(std::string flag_name, T &flag_description) {
return _add_flag_internal(flag_name, CLI::callback_t(), flag_description);
enable_if_t<(std::is_const<typename std::remove_reference<T>::type>::value ||
std::is_rvalue_reference<T &&>::value) &&
std::is_constructible<std::string, typename std::remove_reference<T>::type>::value,
detail::enabler> = detail::dummy>
Option *add_flag(std::string flag_name, T &&flag_description) {
return _add_flag_internal(flag_name, CLI::callback_t(), std::forward<T>(flag_description));
}

/// Other type version accepts all other types that are not vectors such as bool, enum, string or other classes
Expand Down
Loading