Homogenise _geom_angle.value definition #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaitkus
force-pushed
the
homogenise-geom-angle-value-definition
branch
from
0a4a1cc to
819b8b0
Compare
Collaborator
Author
|
The updated version of the dictionary introduced in PR #30 no longer contains the definition of the PR closed since it is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redefined definition lacked some of the aliases and had a different enumeration range compared to the original definition in the coreCIF dictionary.
This PR was raised as a result of discussion in COMCIFS/Powder_Dictionary#176.