This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Fix integer overflow in beacon_dataset_counts_table #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple fix in init.sql currently seems all that is needed. When updating callcounts and variantcounts variant count is likely to overflow on even medium-sized datasets.
blankdots
suggested changes
Oct 7, 2019
Contributor
blankdots
left a comment
blankdots
left a comment
There was a problem hiding this comment.
please make the PR to dev branch as specified in Contributing guidelines.
blankdots
approved these changes
Oct 8, 2019
teemukataja
approved these changes
Oct 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple fix in init.sql currently seems all that is needed. When updating callcounts and variantcounts variant count is likely to overflow on even medium-sized datasets.
Related issues
Type of change
Changes Made
Changed column type on variantcounts from INTEGER to BIGINT
Testing