Skip to content

Conversation

@csc-felipe
Copy link
Contributor

@csc-felipe csc-felipe commented Mar 2, 2023

Description

Dependabot doesn't update pnpm packages, so here's an action to create a PR with pnpm updates.

It's not perfect, though.

  1. It runs when a new PR is created, as cron jobs only run on the default branch
  2. It uses GITHUB_TOKEN, so the new PR doesn't trigger other workflows
  3. PR has to be closed and opened again to run checks

More info:

Related issues

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • Added a new github workflow for automatically updating pnpm packages
  • Change workflows from push to pull_request, so that checks run in the automated PR

Testing

  • Tests do not apply

Mentions

@csc-felipe csc-felipe added dependencies Pull requests that update a dependency file debt Technical debt labels Mar 2, 2023
@csc-felipe csc-felipe self-assigned this Mar 2, 2023
@csc-felipe
Copy link
Contributor Author

It seems to work: #1002

blankdots
blankdots previously approved these changes Mar 2, 2023
@csc-felipe
Copy link
Contributor Author

Not all the checks in that PR are running 🤔

@csc-felipe
Copy link
Contributor Author

I'm thinking that those checks might need to have on: pull_request as well.

@csc-felipe csc-felipe force-pushed the feature/pnpm-auto-update branch 3 times, most recently from b004172 to b4c4d8d Compare March 3, 2023 08:32
blankdots
blankdots previously approved these changes Mar 3, 2023
@csc-felipe
Copy link
Contributor Author

It seems to work if the workflows have on: pull_request. But the generated PR will only work after this is merged to devel, as it changes push to pull_request in workflows.

@csc-felipe csc-felipe requested a review from blankdots March 3, 2023 08:36
@csc-felipe csc-felipe merged commit a8740b2 into devel Mar 3, 2023
@csc-felipe csc-felipe deleted the feature/pnpm-auto-update branch March 3, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Technical debt dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants