Skip to content

Replace buefy snackbars #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 8, 2023
Merged

Replace buefy snackbars #1014

merged 5 commits into from
Mar 8, 2023

Conversation

@mradavi
Copy link
Contributor

@mradavi mradavi commented Mar 7, 2023

Description

Replaced buefy snackbars with custom csc-ui toasts.

Related issues

GL 944

Mentions

Part of PR #1006

@mradavi
Copy link
Contributor Author

mradavi commented Mar 7, 2023

Is there a reason the old snackbar had hard-coded strings that are not in lang.js?

"Encryption engine is ready. Hit refresh to refresh the window to enable encryption.",

@mradavi mradavi requested review from csc-felipe and hannyle March 7, 2023 14:37
@csc-felipe
Copy link
Contributor

csc-felipe commented Mar 7, 2023

Is there a reason the old snackbar had hard-coded strings that are not in lang.js?

I think it was forgotten. Feel free to extract the strings, or create an issue about it.

@hannyle
Copy link
Contributor

hannyle commented Mar 8, 2023

I think the PR also needs a rebase

@mradavi mradavi force-pushed the feature/replace-buefy-snackbars branch from 851778f to 010a654 Compare March 8, 2023 08:51
@mradavi
Copy link
Contributor Author

mradavi commented Mar 8, 2023

I think now it should be fine. I moved the strings, they'll get translated as part of GL 949.

@mradavi mradavi changed the title WIP: Replace buefy snackbars Replace buefy snackbars Mar 8, 2023
csc-felipe
csc-felipe reviewed Mar 8, 2023
View reviewed changes
csc-felipe
csc-felipe reviewed Mar 8, 2023
View reviewed changes
blankdots
blankdots reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question

@csc-felipe csc-felipe merged commit f53da46 into devel Mar 8, 2023
@csc-felipe csc-felipe deleted the feature/replace-buefy-snackbars branch March 8, 2023 11:03
blankdots pushed a commit that referenced this pull request Oct 10, 2023
@mradavi
Merge branch 'bugfix/drop-file-table' into 'devel'
d82922f 
Upload / drop file table issues

Closes #1014 and #1135

See merge request sds-dev/sd-connect/swift-browser-ui!176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannyle hannyle hannyle approved these changes

+2 more reviewers

@csc-felipe csc-felipe csc-felipe left review comments

@blankdots blankdots blankdots approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mradavi @csc-felipe @hannyle @blankdots