Replace buefy components with csc-ui components #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankdots
reviewed
Mar 8, 2023
csc-felipe
force-pushed
the
feature/replace-buefy-components
branch
from
5e3b1f7 to
ecc7f40
Compare
Contributor
Author
|
rebased |
csc-felipe
force-pushed
the
feature/replace-buefy-components
branch
from
ecc7f40 to
b5be0ad
Compare
hannyle
reviewed
Mar 8, 2023
hannyle
reviewed
Mar 8, 2023
csc-felipe
force-pushed
the
feature/replace-buefy-components
branch
from
b5be0ad to
6559bc4
Compare
Contributor
Author
|
resolved comments |
blankdots
previously approved these changes
Mar 8, 2023
hannyle
reviewed
Mar 8, 2023
csc-felipe
force-pushed
the
feature/replace-buefy-components
branch
from
6559bc4 to
7d7f1e4
Compare
Contributor
Author
|
Removed |
hannyle
approved these changes
Mar 8, 2023
blankdots
approved these changes
Mar 9, 2023
blankdots
pushed a commit
that referenced
this pull request
Jun 26, 2023
Sharing to the same container twice did not show error toast Closes #1016 See merge request sds-dev/sd-connect/swift-browser-ui!78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many of buefy components used could already be changed to use
csc-uicomponents.Changes Made
csc-uicsc-uicsc-uicsc-uiTesting
CopyFolderModal.vue- input fieldsCreateFolderModal.vue- input fieldsObjectTable.vue- search boxSelectPage.vue- text input, dropdown, buttonsTokens.vue- text input, dropdown, buttons, data tableMentions
As pointed out by @blankdots, buefy text fields look quite different from csc-ui, as csc-ui text fields look like the ones in material design from Google.
cc @hannyle, @ainoc