Skip to content

Bugfix/refactor pnpm update #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 9, 2023
Merged

Bugfix/refactor pnpm update #1021

merged 3 commits into from
Mar 9, 2023

Conversation

@blankdots
Copy link
Contributor

@blankdots blankdots commented Mar 9, 2023

Description

Related issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • same style for YAML files
  • refine when to run pnpm updates when dependabot update happen for npm or yarn ecosystem, as well allow github actions to run when pushing to dependabot/** branches

Testing

  • Tests do not apply

Mentions

refactored a bit as new understanding how this runs was observed

@blankdots blankdots requested a review from csc-felipe March 9, 2023 11:47
@blankdots blankdots self-assigned this Mar 9, 2023
csc-felipe
csc-felipe approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@csc-felipe csc-felipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand, adding the dependabot push branch will not make a push that happens inside a workflow to trigger other workflows, but it doesn't hurt to try.

@blankdots
Copy link
Contributor Author

blankdots commented Mar 9, 2023

As I understand, adding the dependabot push branch will not make a push that happens inside a workflow to trigger other workflows, but it doesn't hurt to try.

i see, well let us try, if not I will try something else

@blankdots blankdots merged commit eac2f19 into devel Mar 9, 2023
@blankdots blankdots deleted the bugfix/refactor-pnpm-update branch March 9, 2023 12:30
blankdots pushed a commit that referenced this pull request May 30, 2023
Merge branch 'feature/notify-duplicate-file' into 'devel'
3963002 
Upload / Notify about adding a duplicate file

Closes #1021 and #1026

See merge request sds-dev/sd-connect/swift-browser-ui!43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@csc-felipe csc-felipe csc-felipe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@blankdots blankdots

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blankdots @csc-felipe