Skip to content

Change buefy.dialogs to csc-ui modals #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 13, 2023
Merged

Change buefy.dialogs to csc-ui modals #1024

merged 9 commits into from
Mar 13, 2023

Conversation

@emm1R
Copy link
Member

@emm1R emm1R commented Mar 10, 2023

Description

Replace buefy-dialogs with csc-ui modals.

Related issues

GL 944

@emm1R emm1R self-assigned this Mar 10, 2023
@emm1R emm1R marked this pull request as ready for review March 10, 2023 06:48
@emm1R emm1R requested review from blankdots and csc-felipe March 10, 2023 06:49
@hannyle
Copy link
Contributor

hannyle commented Mar 10, 2023 •
edited
Loading

Delete works, but if someone could clarify the use cases of this.$route.params.owner and this.$route.params.project?

this.$route.params.owner refers to the project owner (project ID) that has shared a Folder/Container to us in Folders shared with you

@hannyle
Copy link
Contributor

hannyle commented Mar 10, 2023

Could we have the DeleteModal looked a bit more similar to Figma design ?

Screenshot 2023-03-10 at 9 45 10

csc-felipe
csc-felipe reviewed Mar 10, 2023
View reviewed changes
@csc-felipe
Copy link
Contributor

csc-felipe commented Mar 10, 2023 •
edited
Loading

Can be rebased to fix tests, now that #1025 was merged.

@emm1R emm1R requested a review from csc-felipe March 10, 2023 09:39
@csc-felipe csc-felipe requested a review from hannyle March 10, 2023 10:29
@emm1R emm1R requested a review from hannyle March 10, 2023 15:37
@hannyle hannyle merged commit 5e4e903 into devel Mar 13, 2023
@hannyle hannyle deleted the feature/replace-buefy-dialog branch March 13, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannyle hannyle hannyle approved these changes

@blankdots blankdots Awaiting requested review from blankdots

@csc-felipe csc-felipe Awaiting requested review from csc-felipe

Assignees

@emm1R emm1R

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emm1R @hannyle @csc-felipe