Skip to content

Feature/update language #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 30, 2023
Merged

Feature/update language #1032

merged 16 commits into from
Mar 30, 2023

Conversation

@mradavi
Copy link
Contributor

@mradavi mradavi commented Mar 14, 2023 •
edited
Loading

Description

Many many UI language changes

Related issues

GL 949

Changes Made

  • All-over language updates with UX lead
    • Removed a subtitle from ShareModal
  • Removed unused strings
  • Moved CSC specific language and links to override files (on GL), left more generic versions here
  • Fixed a menu link
  • Included the instruction changes in ShareModal from an older issue
  • Removed unused legacy mobile navigation menu

@mradavi mradavi changed the title WIP: Feature/update language Feature/update language Mar 24, 2023
@mradavi mradavi requested review from csc-felipe and hannyle March 24, 2023 08:20
@mradavi mradavi force-pushed the feature/update-language branch from 1d242d8 to dee80a0 Compare March 29, 2023 09:10
sampsapenna
sampsapenna requested changes Mar 29, 2023
View reviewed changes
Copy link
Member

@sampsapenna sampsapenna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Share modal is broken due to new vue-i18n not returning anything but strings with the default $t.

@mradavi @sampsapenna
Fix list in ShareModal instructions
f4a6868 
Co-authored-by: Sampsa penna <24293337+sampsapenna@users.noreply.github.com>
sampsapenna
sampsapenna approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@sampsapenna sampsapenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍🏼

@csc-felipe csc-felipe merged commit 98f146c into devel Mar 30, 2023
@csc-felipe csc-felipe deleted the feature/update-language branch March 30, 2023 12:47
blankdots pushed a commit that referenced this pull request May 30, 2023
@mradavi
Merge branch 'bugfix/open-shared-folder' into 'devel'
e18d396 
Fix shared folder redirection to /unauth

Closes #1032

See merge request sds-dev/sd-connect/swift-browser-ui!47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampsapenna sampsapenna sampsapenna approved these changes

@hannyle hannyle Awaiting requested review from hannyle

@csc-felipe csc-felipe Awaiting requested review from csc-felipe

Assignees

@mradavi mradavi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mradavi @sampsapenna @csc-felipe