Skip to content

Conversation

@hannyle
Copy link
Contributor

@hannyle hannyle commented Mar 15, 2023

Description

Replace Buefy Autocomplete component to csc-ui component.

Related issues

GL issue 944

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • My prior PR for adding possibility to have custom menu items in csc-ui repo
  • Since that PR is still waiting for review and not yet merged to csc-ui master branch, I used my forked repo from csc-ui to continue developing our own Autcomplete component
  • Updated Changelog

Testing

  • Manual testing

@hannyle hannyle changed the title WIP: Feature/replace buefy autocomplete Feature/replace buefy autocomplete Mar 15, 2023
@hannyle hannyle self-assigned this Mar 15, 2023
@hannyle hannyle added enhancement New feature or request dependencies Pull requests that update a dependency file debt Technical debt labels Mar 15, 2023
csc-felipe
csc-felipe previously approved these changes Mar 16, 2023
Copy link
Contributor

@csc-felipe csc-felipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, well done

- Add option to go to another view on key enter a menu item
@hannyle
Copy link
Contributor Author

hannyle commented Mar 17, 2023

Is it okay if I merge this PR with csc-ui forked repo as dependency? We could change it back to the correct version when the design system team merges my PR?

@csc-felipe
Copy link
Contributor

Yes, let's do it like that

@hannyle hannyle merged commit 49daaef into devel Mar 17, 2023
@hannyle hannyle deleted the feature/replace-buefy-autocomplete branch March 17, 2023 10:59
blankdots pushed a commit that referenced this pull request Jun 22, 2023
Show the right toasts in CreateModal

Closes #1033

See merge request sds-dev/sd-connect/swift-browser-ui!74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Technical debt dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants