Skip to content

Feature/token modal #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 31, 2023
Merged

Feature/token modal #1038

merged 13 commits into from
Mar 31, 2023

Conversation

@mradavi
Copy link
Contributor

@mradavi mradavi commented Mar 21, 2023 •
edited
Loading

Description

Replacing token view with a token modal based on a figma design. Modal contains a c-alert notifying user to save the token. A table of identifiers of existing tokens is displayed below.

Related issues

GL 940

Changes Made

  • removed token route
  • token modal state saved in store
  • main navbar changed to open the modal
  • language in the modal changed accordingly
  • deleted Tokens.vue
  • a lot of the TokenModal code comes from the old Tokens.vue
  • added new toasts: after deleting tokens, entering an already existing identifier, token creation failures

@mradavi mradavi changed the title WIP: Feature/token modal Feature/token modal Mar 23, 2023
@mradavi mradavi requested review from csc-felipe and hannyle March 23, 2023 13:56
@mradavi

This comment was marked as outdated.

Sign in to view
@mradavi mradavi force-pushed the feature/token-modal branch from aedbd53 to adce6d0 Compare March 29, 2023 07:14
@mradavi
Copy link
Contributor Author

mradavi commented Mar 29, 2023

It should open now @sampsapenna !

sampsapenna
sampsapenna previously approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@sampsapenna sampsapenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked great, approved! 👍🏼

@csc-felipe
Copy link
Contributor

csc-felipe commented Mar 30, 2023

Need to rebase after your other PR was merged ^^

@mradavi mradavi force-pushed the feature/token-modal branch from 9a57e56 to 96f0e5d Compare March 30, 2023 13:12
@blankdots blankdots merged commit b64964d into devel Mar 31, 2023
@blankdots blankdots deleted the feature/token-modal branch March 31, 2023 04:40
blankdots pushed a commit that referenced this pull request Jun 19, 2023
@mradavi
Merge branch 'bugfix/copy-container-segments' into 'devel'
b5b3e57 
Add segment container to copied containers

Closes #1036 and #1038

See merge request sds-dev/sd-connect/swift-browser-ui!62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampsapenna sampsapenna sampsapenna approved these changes

@hannyle hannyle Awaiting requested review from hannyle

@csc-felipe csc-felipe Awaiting requested review from csc-felipe

Assignees

@mradavi mradavi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mradavi @csc-felipe @sampsapenna @blankdots