Skip to content

Conversation

@hannyle
Copy link
Contributor

@hannyle hannyle commented Mar 24, 2023

Description

  • Subfolders and files should be all selectable by checking checkbox
  • Subfolders shouldn't be deleted before deleting all files inside it
  • Files should be able to select and mass delete

Related issues

GL 933 & 936 & 974

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • Added folder icon for sub-folders
  • Added prefix to file's names so the file names are matched when its checkbox is selected
  • Changed Display as text to Display as path to make the term more understandable
  • Prevented subfolders from being deleted when clicking Delete button or selecting together with files
  • Updated Changelog

Testing

  • Needs testing (manual test)

Mention

  • Since we have now subfolders and files in the same view, some notifications when selecting and deleting them are not clear enough and still not in correct timing/visual order
  • The terms and text are still not so clear since we only have objects before, now objects could mean subfolders and `files``
    --> These things should be fixed in another PR while waiting for the UI design from @ainoc

@hannyle hannyle self-assigned this Mar 24, 2023
@hannyle hannyle added bug Something isn't working enhancement New feature or request labels Mar 24, 2023
@hannyle hannyle changed the title WIP: Bugfix/selecting all files Bugfix/Selecting subfolders and files Mar 24, 2023
@hannyle hannyle changed the title Bugfix/Selecting subfolders and files WIP: Bugfix/Selecting subfolders and files Mar 24, 2023
@hannyle
Copy link
Contributor Author

hannyle commented Mar 24, 2023

Noticed an issue with this, I will make changes

@hannyle
Copy link
Contributor Author

hannyle commented Mar 24, 2023

Ready for review

Figured out some small bugs related to this after talking with Aino-Riikka so I will fix them here

@hannyle hannyle changed the title WIP: Bugfix/Selecting subfolders and files Bugfix/Selecting subfolders and files Mar 24, 2023
@hannyle hannyle changed the title Bugfix/Selecting subfolders and files WIP: Bugfix/Selecting subfolders and files Mar 24, 2023
@hannyle hannyle force-pushed the bugfix/selecting-all-files branch 2 times, most recently from c4dd77f to b29dab1 Compare March 28, 2023 08:00
@hannyle hannyle changed the title WIP: Bugfix/Selecting subfolders and files Fix for selecting and deleting subfolders and files Mar 28, 2023
@hannyle
Copy link
Contributor Author

hannyle commented Mar 28, 2023

A follow-up PR will be needed when the UI design is ready, as I wrote in the Mention part

@mradavi mradavi force-pushed the bugfix/selecting-all-files branch from b29dab1 to bec71aa Compare March 31, 2023 06:29
Copy link
Member

@sampsapenna sampsapenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, and displaying only the paths of the current folder recursively is indeed more intuitive than the old behavior. Uploads into nested folders still works as well, so I didn't notice any regressions.

LGTM 👍🏼

@csc-felipe csc-felipe merged commit bb7598f into devel Mar 31, 2023
@csc-felipe csc-felipe deleted the bugfix/selecting-all-files branch March 31, 2023 07:14
@blankdots blankdots linked an issue Mar 31, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete folder doesn't work

6 participants