-
Notifications
You must be signed in to change notification settings - Fork 5
Fix for selecting and deleting subfolders and files #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Noticed an issue with this, I will make changes |
|
Figured out some small bugs related to this after talking with Aino-Riikka so I will fix them here |
c4dd77f to
b29dab1
Compare
|
A follow-up PR will be needed when the UI design is ready, as I wrote in the Mention part |
b29dab1 to
bec71aa
Compare
sampsapenna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely, and displaying only the paths of the current folder recursively is indeed more intuitive than the old behavior. Uploads into nested folders still works as well, so I didn't notice any regressions.
LGTM 👍🏼
Description
Related issues
GL 933 & 936 & 974
Type of change
Changes Made
prefixto file's names so thefilenames are matched when its checkbox is selectedDisplay as texttoDisplay as pathto make the term more understandablesubfoldersfrom being deleted when clickingDeletebutton or selecting together withfilesTesting
Mention
subfoldersandfilesin the same view, some notifications when selecting and deleting them are not clear enough and still not in correct timing/visual orderobjectsbefore, nowobjectscould meansubfoldersand `files``--> These things should be fixed in another PR while waiting for the UI design from @ainoc