Skip to content

Add some missing python unit tests 🚧 #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add some missing python unit tests 🚧 #1042

wants to merge 3 commits into from

Conversation

@csc-jm
Copy link
Contributor

@csc-jm csc-jm commented Mar 30, 2023 •
edited
Loading

Description

This PR adds some missing unit test cases I found. The changes in this PR at the moment reach ~71% coverage (hence 🚧), but I'm also working to add some tests to upload/cryptupload.py, upload/download.pyand upload/replicate.py, which don't have any at all the moment. After those are added, we should have coverage of at least 75%

Related issues

Part of issue 948 on GitLab

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • added python unit tests
  • fixed a typo

Testing

  • Unit Tests

Mentions

@csc-jm csc-jm self-assigned this Mar 30, 2023
csc-jm
csc-jm commented Mar 30, 2023
View reviewed changes
swift_browser_ui/ui/health.py
Copy link
Contributor Author

@csc-jm csc-jm Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I interpreted this as a typo (?)

@csc-jm csc-jm force-pushed the test/increase-unit-testing-coverage branch from a121c10 to aecab50 Compare March 30, 2023 17:02
@csc-felipe
Copy link
Contributor

csc-felipe commented Mar 31, 2023

I'm sorry, but we're migrating development away from Github, and PRs are not being created here anymore.

@csc-felipe csc-felipe closed this Mar 31, 2023
@blankdots blankdots deleted the test/increase-unit-testing-coverage branch July 27, 2023 06:16
blankdots pushed a commit that referenced this pull request Oct 30, 2023
Merge branch 'feature/show-created-folder-on-top' into 'devel'
1560289 
Newly created folder is temporarily shown first in table

Closes #1151 and #1042

See merge request sds-dev/sd-connect/swift-browser-ui!191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csc-felipe csc-felipe Awaiting requested review from csc-felipe

@sampsapenna sampsapenna Awaiting requested review from sampsapenna

Assignees

@csc-jm csc-jm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@csc-jm @csc-felipe