Feature/npm refactor #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the frontend build allows not uploading the dist folder produced by the `npm run build` command, while still allowing testing the program automatically.
sampsapenna
force-pushed
the
feature/npm-refactor
branch
from
6155a6b to
b3130bf
Compare
blankdots
suggested changes
Sep 18, 2019
Contributor
blankdots
left a comment
blankdots
left a comment
There was a problem hiding this comment.
Not sure I follow the need to have both swift_browser_ui_frontend and swift_browser_ui_frontend.old folders. I think we should remove the .old one
I think we should add in the style check stage the npm run lint.
After these changes are done I will resume review.
Refactor tests folders
- Disable checks for property typing - Shorten getContainerAddress function naming to stay under line limit - Add some recommended things in .gitignore regarding js - Fix linter errors in module.exports row, since the linter is wrong on this one.
Docker stage for frontend node.js build
blankdots
force-pushed
the
feature/npm-refactor
branch
from
692b89d to
a454c81
Compare
blankdots
approved these changes
Sep 19, 2019
sampsapenna
pushed a commit
that referenced
this pull request
Jul 27, 2021
Add authentication support to bindings module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the frontend to use npm for package management and vue-cli for
builds to make development easier.
Type of change
Changes Made
Testing
New PR was created concerning testing the newly refactored JS. (#22)