Skip to content

Fix Python unit and style tests #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Fix Python unit and style tests #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
061f300
Fix unit-tests by fixing variable type to datetime.
csc-felipe Nov 10, 2022
5ca82ac
Fix mypy tests
csc-felipe Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion swift_browser_ui/upload/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ def __init__(self) -> None:
maxsize=int(os.environ.get("SWIFT_UPLOAD_RUNNER_PROXY_Q_SIZE", 1024))
)

def write(self, payload: bytes = None) -> None:
def write(self, payload: bytes) -> None:
"""Emulate BytesIO write function to be used with tarfile."""
self.q.put(payload)

Expand Down
4 changes: 2 additions & 2 deletions tests/sharing/test_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ class AsyncpgConnectionMock:
"r_read": True,
"r_write": True,
"container": "test-container",
"sharingdate": "15 July 2020",
"sharingdate": mock_date,
"container_owner": "test-owner",
"recipient": "test-recipient",
"address": "test-address",
Expand Down Expand Up @@ -170,7 +170,7 @@ async def __aexit__(self, *args, **kwargs):
"r_read": True,
"r_write": True,
"container": "test-container",
"sharingdate": "15 July 2020",
"sharingdate": mock_date,
"container_owner": "test-owner",
"recipient": "test-recipient",
"address": "test-address",
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ deps =
# Mypy fails if 3rd party library doesn't have type hints configured.
# Alternative to ignoring imports would be to write custom stub files, which
# could be done at some point.
commands = mypy --ignore-missing-imports swift_browser_ui/
commands = mypy --ignore-missing-imports --no-namespace-packages swift_browser_ui/

[testenv:docs]
; skip_install = true
Expand Down