Skip to content

Conversation

@hannyle
Copy link
Contributor

@hannyle hannyle commented Nov 16, 2022

Description

  • Fixing bugs related to modals' size and the background page's scrolling effect when opening/closing modals.
  • Copy modal will now have a pre-filled foldername as copy from the original foldername. For example: Original foldername is Folder ABC, the pre-filled copy foldername will be Folder ABC copy 1.

Related issues

Fixes #798, #799, #812, #813, #817, #823,

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • Created a function to check and convert the current foldername to a copy foldername in the form of foldername + "copy" + "version". The version increments every time we create a new copy of the same foldername.
  • Checking if folder already exists in Copy modal will only fire when user starts modifying the foldername
  • Updated Changelog

Testing

  • Tests do not apply

Mentions

@hannyle hannyle self-assigned this Nov 16, 2022
@hannyle hannyle added bug Something isn't working enhancement New feature or request labels Nov 16, 2022
@hannyle hannyle marked this pull request as draft November 16, 2022 13:14
@hannyle hannyle changed the title Bugfix/bug fixes for modals Bugfix/multiple bug fixes for modals Nov 17, 2022
@hannyle hannyle marked this pull request as ready for review November 17, 2022 07:38
@hannyle hannyle requested a review from sampsapenna November 17, 2022 07:38
@hannyle hannyle force-pushed the bugfix/bug-fixes-for-modals branch from 870ed02 to 960e61f Compare November 17, 2022 07:41
@hannyle hannyle force-pushed the bugfix/bug-fixes-for-modals branch from c538214 to 7e34c2e Compare November 17, 2022 10:11
Copy link
Member

@sampsapenna sampsapenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@hannyle hannyle merged commit fc80874 into devel Dec 27, 2022
@hannyle hannyle deleted the bugfix/bug-fixes-for-modals branch December 27, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

3 participants