Skip to content

Bugfix/fixes for data table #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 5, 2023
Merged

Bugfix/fixes for data table #871

merged 5 commits into from
Jan 5, 2023

Conversation

@hannyle
Copy link
Contributor

@hannyle hannyle commented Nov 29, 2022 •
edited
Loading

Description

Fixed for folder's Options/Rights in data table, fixed for table's sorting functionality, and modified modals to have similar width.

Related issues

Fixes #801, #815, #803, #808, #816

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • Checked accessRights of folders and greyed out some table's options according to folder's Shared status
  • Fixed for sorting functionality for table's Name and Items columns
  • Modified modals to have the same width

Testing

  • Unit Tests
  • Integration Tests
  • Tests do not apply

Mentions

@hannyle hannyle force-pushed the bugfix/fixes-for-data-table branch from 43ac98e to 5196cfd Compare November 29, 2022 08:57
@hannyle hannyle requested a review from sampsapenna November 29, 2022 09:17
@hannyle hannyle self-assigned this Nov 29, 2022
@hannyle hannyle added bug Something isn't working enhancement New feature or request labels Nov 29, 2022
This was linked to issues Nov 29, 2022
Folder shared with you / Read rights / Options #801
Closed
Folders datatable / bugs in sorting by name #808
Closed
Folder shared with you / Read and write rights / Options #815
Closed
Modals / Add minimun width and height #816
Closed
sampsapenna
sampsapenna requested changes Dec 22, 2022
View reviewed changes
@hannyle hannyle force-pushed the bugfix/fixes-for-data-table branch from 5196cfd to db3fced Compare December 27, 2022 12:19
@hannyle hannyle requested a review from sampsapenna December 27, 2022 12:20
sampsapenna
sampsapenna requested changes Jan 5, 2023
View reviewed changes
Copy link
Member

@sampsapenna sampsapenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebasing before merge, otherwise LGTM 👍🏼

@hannyle hannyle force-pushed the bugfix/fixes-for-data-table branch from db3fced to ad453aa Compare January 5, 2023 13:06
@hannyle
Copy link
Contributor Author

hannyle commented Jan 5, 2023

Needs rebasing before merge, otherwise LGTM 👍🏼

It is now rebased on latest devel branch

@hannyle hannyle requested a review from sampsapenna January 5, 2023 13:07
@hannyle hannyle force-pushed the bugfix/fixes-for-data-table branch from ad453aa to ccccd73 Compare January 5, 2023 13:24
@hannyle hannyle merged commit 4ed223e into devel Jan 5, 2023
@hannyle hannyle deleted the bugfix/fixes-for-data-table branch January 5, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampsapenna sampsapenna sampsapenna approved these changes

Assignees

@hannyle hannyle

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

3 participants

@hannyle @sampsapenna