Bugfix/multiple bug fixes #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 7, 2022
sampsapenna
requested changes
Dec 22, 2022
Member
sampsapenna
left a comment
sampsapenna
left a comment
There was a problem hiding this comment.
Added a comment about translation, it can be substituted into the Finnish tooltip if need be
hannyle
force-pushed
the
bugfix/multiple-bug-fixes
branch
from
ad8ae99 to
871e4f0
Compare
Contributor
|
in order for this to pass in python unit tests, you need #893 |
hannyle
force-pushed
the
bugfix/multiple-bug-fixes
branch
from
871e4f0 to
8a48c62
Compare
Closed
Closed
sampsapenna
requested changes
Jan 5, 2023
Member
sampsapenna
left a comment
sampsapenna
left a comment
There was a problem hiding this comment.
There are still linter errors present in JS code, so run npm run lint before merging. Otherwise LGTM, so I'll directly approve after that 👍🏼
hannyle
force-pushed
the
bugfix/multiple-bug-fixes
branch
from
8a48c62 to
2544245
Compare
- Fix Notification for removing a shared permission - Fix function when removing a permission
hannyle
force-pushed
the
bugfix/multiple-bug-fixes
branch
from
2544245 to
9ccc9a1
Compare
Contributor
Author
Thank you for pointing that out. I fixed the Lint issue and rebased on |
sampsapenna
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing multiple bugs related to modals and router.
Related issues
Fixes #822, #856, #866, #870, #873, #799 (comment)
Type of change
Changes Made
Testing
Mentions