Remove `rotate_from_matrix` #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

viljarjf wants to merge 1 commit into CSSFrancis:use_phase_class2 from viljarjf:remove_rotate_from_matrix

viljarjf commented May 4, 2024

Description of the change

Removes ReciprocalLatticeVector.rotate_from_matrix, and "manually" rotate instead where it was used

Progress of the PR

Docstrings for all functions
Unit tests with pytest for all lines
[] Clean code style by running black (some unrelated files were formatted when I ran black)

For reviewers

The PR title is short, concise, and will make sense 1 year later.
New functions are imported in corresponding __init__.py.
New features, API changes, and deprecations are mentioned in the
unreleased section in CHANGELOG.rst.
Contributor(s) are listed correctly in credits in diffsims/release_info.py and
in .zenodo.json.


          Remove rotate_from_matrix

03a14e7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet