Skip to content

Conversation

@nschonni
Copy link
Member

Setting the build request on each PR causes alot of diff noise. It only really needs to be set when a new version is released.

@nschonni
Copy link
Member Author

@nzakas should I close this? Maybe it just bothers me and no one else.

@nzakas
Copy link
Contributor

nzakas commented Dec 17, 2012

Sorry, didn't mean to ignore you - life has been crazy. This is a PITA for
sure, but I think the real solution is to just not check-in the build
directory. I can't think of a reason why it would be needed.

On Sun, Dec 16, 2012 at 8:57 PM, Nick Schonning notifications@github.comwrote:

@nzakas https://github.com/nzakas should I close this? Maybe it just
bothers me and no one else.


Reply to this email directly or view it on GitHubhttps://github.com//pull/45#issuecomment-11430531.


Nicholas C. Zakas
@SlickNet

Author, Professional JavaScript for Web Developers
Buy it at Amazon.com:
http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3

@nschonni
Copy link
Member Author

The build directory is referenced by the CSSLint build for updating their copy

@SLaks
Copy link

SLaks commented Dec 17, 2012

While we're tweaking the build system, can there be a way to reference the latest parserlib directly GitHub using NPM?

(an unversioned package.json in the repo root)

@nzakas
Copy link
Contributor

nzakas commented Dec 17, 2012

Actually, CSSLint references the release directory.

I don't want to drastically change the repo layout to support NPM, and I
think having two package.json files would be confusing to people. Do you
have another suggestion?

On Mon, Dec 17, 2012 at 10:19 AM, SLaks notifications@github.com wrote:

While we're tweaking the build system, can there be a way to reference the
latest parserlib directly GitHub using NPM?

(an unversioned package.json in the repo root)


Reply to this email directly or view it on GitHubhttps://github.com//pull/45#issuecomment-11453172.


Nicholas C. Zakas
@SlickNet

Author, Professional JavaScript for Web Developers
Buy it at Amazon.com:
http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3

@nschonni
Copy link
Member Author

The release directory is populated by copying the build directory files https://github.com/nzakas/parser-lib/blob/master/build.xml#L208

@nzakas
Copy link
Contributor

nzakas commented Dec 17, 2012

Yes, I'm aware. The build directory will still be generated locally in
order to create a release, but it doesn't have to be checked in.

On Mon, Dec 17, 2012 at 10:36 AM, Nick Schonning
notifications@github.comwrote:

The release directory is populated by copying the build directory files
https://github.com/nzakas/parser-lib/blob/master/build.xml#L208


Reply to this email directly or view it on GitHubhttps://github.com//pull/45#issuecomment-11453846.


Nicholas C. Zakas
@SlickNet

Author, Professional JavaScript for Web Developers
Buy it at Amazon.com:
http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3

@SLaks
Copy link

SLaks commented Dec 17, 2012

Unfortunately, npm cannot install packages from subdirectories of git repos (isaacs/npm#2974).

Also, there is currently no valid package.json file for the latest source (npm balks on raw @VERSION@ tags)

@nschonni
Copy link
Member Author

@nzakas your suggestion is to add the build folder to the .gitignore instead?
@SLaks you might want to start a separate issue as the conversation isn't really related

@nzakas
Copy link
Contributor

nzakas commented Dec 18, 2012

Yup, exactly.

On Mon, Dec 17, 2012 at 2:09 PM, Nick Schonning notifications@github.comwrote:

@nzakas https://github.com/nzakas your suggestion is to add the build
folder to the .gitignore instead?
@SLaks https://github.com/SLaks you might want to start a separate
issue as the conversation isn't really related


Reply to this email directly or view it on GitHubhttps://github.com//pull/45#issuecomment-11464058.


Nicholas C. Zakas
@SlickNet

Author, Professional JavaScript for Web Developers
Buy it at Amazon.com:
http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3

@nschonni
Copy link
Member Author

@nzakas will you do that yourself or should a do another PR?

@nschonni nschonni closed this Dec 18, 2012
mattiacci pushed a commit to mattiacci/parser-lib that referenced this pull request Dec 8, 2013
These files were causing alot  of diff noise with the timestamps.
Discussed in CSSLint#45
@varun1996
Copy link

npm/npm#2974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants