This repository was archived by the owner on Sep 18, 2020. It is now read-only.
For Edgardo to check #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medgardo
reviewed
Sep 7, 2017
index.html
Outdated
| <h3>Peanut Butter Cookies</h3> | ||
| <p>Yummy peanut buttery goodness!</p> | ||
| </div> | ||
| </div> |
Member
There was a problem hiding this comment.
A couple of things are happening here.
- On line 54, you're moving the column to an offset of 4 but it doesn't have a size. This parent div will limit the width for the cookie
h3,p, andimgtags - You should not change the order of the h3, p, and img tags. Semantically the img tag belongs below the h3 heading
- The way you wrapped the img tag and the h3 and p tag is good, and using the push and pull classes is also good. The issue here is that those two column don't add up to 12. You hacked to be centered by only using 7 columns, and having the parent offset by 4.
You should fix the other cookie product listings as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.