Improved loading of configuration files #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CVarisco
approved these changes
Nov 23, 2017
Owner
|
Very great job man! I'll publish a new version as soon as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we threw an error if we couldn't find a configuration file.
I changed this, so we would only throw if the parsing of the configuration file failed.
This fixes parts of this issue (#55).
If the user runs
create-component-appwithout a configuration file, it will no longer report"Bad config file, Please check config file syntax.", but a message informing the user thatwe couldn't find a configuration file and continue with defaults.
I also moved the example config, which we inlined into the readme, to an example config file,
and the comments explaining the different options to a markdown table.