Adios on 6.17-rc4 does not compile

[bermeitinger-b]

This commit: torvalds/linux@f5a6604 introduced a different interface than the one used in adios.c.

block/adios.c:1336:26: error: too few arguments to function call, expected 3, have 2
 1336 |         eq = elevator_alloc(q, e);
      |              ~~~~~~~~~~~~~~     ^
block/elevator.h:165:24: note: 'elevator_alloc' declared here
  165 | struct elevator_queue *elevator_alloc(struct request_queue *,
      |                        ^              ~~~~~~~~~~~~~~~~~~~~~~~
  166 |                 struct elevator_type *, struct elevator_tags *);
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
block/adios.c:1852:19: error: incompatible function pointer types initializing 'int (*)(struct request_queue *, struct elevator_queue *)' with an expression of type 'int (struct request_queue *, struct elevator_type *)' [-Wincompatible-function-pointer-types]
 1852 |                 .init_sched                     = adios_init_sched,
      | 

My C and kernel skills are not good enough to propose a patch set.

[ptr1337]

The compilation on our server went fine so far. Do you have ADIOS disabled or did pull the latest patches?

[firelzrd]

That error should occur if a 6.16.0-adios patch is applied on Linux 6.17 series.
Please check your patch version, and make sure you're using the right patch.

I've also updated ADIOS patch for Linux 6.16 series to target the new 6.16.4 which includes the equivalent changes to Linux 6.17 series.
So now you can apply ADIOS on top of Linux 6.17, no matter you use 6.16-adios or 6.17-adios patch.

Have fun :)

[ptr1337]

Sorry, ignore my message. Appears ive disabled it in our config

[bermeitinger-b]

Thank you. I did in fact reuse the previous config (rc3) which enables Adios while the config for rc4 disables it. With this, it compiles. (Without adios, is my guess, right?)

[ptr1337]

Thank you. I did in fact reuse the previous config (rc3) which enables Adios while the config for rc4 disables it. With this, it compiles. (Without adios, is my guess, right?)

We have enabled ADIOS now again and it should compile correctly