Skip to content

Conversation

@Jojain
Copy link
Contributor

@Jojain Jojain commented Mar 7, 2021

move images in example/images folder + add images for all the workings examples (except numpy.py) + add the images in the readme.md file

move images in example/images folder + add images for all the workings examples + add the images in the readme.md file
@jmwright
Copy link
Member

@Jojain Is this still WIP? There's code commented out in tray.py and I don't see the changes to add the images to the readme.

@Jojain
Copy link
Contributor Author

Jojain commented Mar 10, 2021

Indeed I somehow didn't uploaded the readme file.
I uncommented the code that was left and now it shoud be finished.

@jmwright jmwright self-requested a review March 10, 2021 18:22
@jmwright
Copy link
Member

@Jojain Did you use the HTML tag instead of the markdown tag so that you could make the image widths consistent?

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jojain !

@jmwright jmwright merged commit da69d51 into CadQuery:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants