Skip to content

Fix empty render in docs and doc build error #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2023
Merged

Fix empty render in docs and doc build error #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39bf51b
Fix empty render in docs and doc build error
lorenzncode Jul 6, 2023
afdc4db
Update cadquery/occ_impl/assembly.py
lorenzncode Jul 6, 2023
57d815a
Skip CQGI assignment of unsupported parameter type (tuple)
lorenzncode Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions cadquery/cqgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,9 +560,13 @@ def visit_Assign(self, node):
if type(node.value) in astTypes:
self.handle_assignment(left_side.id, node.value)
elif type(node.value) == ast.Tuple:
# we have a multi-value assignment
for n, v in zip(left_side.elts, node.value.elts):
self.handle_assignment(n.id, v)
if isinstance(left_side, ast.Name):
# skip unsupported parameter type
pass
else:
# we have a multi-value assignment
for n, v in zip(left_side.elts, node.value.elts):
self.handle_assignment(n.id, v)
except:
traceback.print_exc()
print("Unable to handle assignment for node '%s'" % ast.dump(left_side))
Expand Down
2 changes: 1 addition & 1 deletion cadquery/occ_impl/assembly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ def toJSON(

val: Any = {}

data = toString(Compound.makeCompound(assy.shapes), tolerance)
data = toString(shape, tolerance)
trans, rot = loc.toTuple()

val["shape"] = data
Expand Down