Skip to content

Conversation

sethfischer
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #1372 (cddb17e) into master (fa0abf0) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head cddb17e differs from pull request most recent head 0929ad7. Consider uploading reports for the commit 0929ad7 to get more accurate results

@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
- Coverage   94.14%   94.10%   -0.05%     
==========================================
  Files          26       26              
  Lines        5601     5613      +12     
  Branches      952      957       +5     
==========================================
+ Hits         5273     5282       +9     
- Misses        195      198       +3     
  Partials      133      133              
Impacted Files Coverage Δ
cadquery/cqgi.py 79.67% <100.00%> (-1.07%) ⬇️
cadquery/occ_impl/assembly.py 97.27% <100.00%> (ø)
cadquery/occ_impl/exporters/svg.py 96.92% <100.00%> (+0.25%) ⬆️
cadquery/occ_impl/importers/__init__.py 94.44% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sethfischer sethfischer force-pushed the import-step-typing branch 2 times, most recently from 91f1927 to 5323ff0 Compare July 9, 2023 00:52
@sethfischer sethfischer changed the title Typing for importStep() Typing for importStep() and importShape() Jul 9, 2023
@sethfischer sethfischer marked this pull request as ready for review July 9, 2023 01:33
@sethfischer sethfischer force-pushed the import-step-typing branch from 5323ff0 to 0929ad7 Compare July 9, 2023 01:38
Copy link
Member

@adam-urbanczyk adam-urbanczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adam-urbanczyk adam-urbanczyk requested a review from jmwright July 18, 2023 16:05
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sethfischer !

@jmwright jmwright merged commit 396f0ad into CadQuery:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants