-
Notifications
You must be signed in to change notification settings - Fork 381
Making all download formats of the RTD documentation available #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@adam-urbanczyk @lorenzncode I think this one should be pretty straight forward. Related RTD documentation here and here. |
Codecov Report
@@ Coverage Diff @@
## master #1377 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 27 27
Lines 5671 5671
Branches 961 961
=======================================
Hits 5338 5338
Misses 199 199
Partials 134 134 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, how will a pdf +vtkjs look like though?
I honestly don't know. I thought that RTD might build the artifacts for a PR so that we could check them, but it didn't. |
From https://docs.readthedocs.io/en/stable/guides/pull-requests.html#limitations
|
I believe the Sphinx directives in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps go ahead with this PR and try 'all' to see what it looks like now. Then limit to htmlzip until when/if PDF is better supported.
Ok, I'll try it. I don't know that any of us have our GitHub accounts linked to RTD (a requirement for enabling PR builds). At least the accounts for Dave and I predate that login option. |
Closes #1352
It should make zipped HTML, PDF and epub formats available for download.