Skip to content

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Sep 22, 2023

  • Implementation
  • Tests
  • Docs
  • Refactor - move more stuff to shape (?)

@adam-urbanczyk adam-urbanczyk marked this pull request as draft September 22, 2023 06:49
@adam-urbanczyk adam-urbanczyk linked an issue Sep 22, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #1406 (038cbe7) into master (d780127) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1406      +/-   ##
==========================================
+ Coverage   94.19%   94.23%   +0.03%     
==========================================
  Files          27       28       +1     
  Lines        5740     5779      +39     
  Branches      983      984       +1     
==========================================
+ Hits         5407     5446      +39     
  Misses        199      199              
  Partials      134      134              
Files Coverage Δ
cadquery/occ_impl/shape_protocols.py 100.00% <100.00%> (ø)
cadquery/occ_impl/shapes.py 93.15% <100.00%> (+0.07%) ⬆️
cadquery/selectors.py 98.88% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmwright
Copy link
Member

jmwright commented Oct 4, 2023

@adam-urbanczyk This PR is still marked as draft. Is this an interim review, or a final review? All the tests are in place and pass, so I wondered if maybe the intent was to take the PR out of draft.

@adam-urbanczyk adam-urbanczyk marked this pull request as ready for review October 4, 2023 17:32
@adam-urbanczyk
Copy link
Member Author

@adam-urbanczyk This PR is still marked as draft. Is this an interim review, or a final review? All the tests are in place and pass, so I wondered if maybe the intent was to take the PR out of draft.

I forgot to undraft it.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things seem to work well as far as I can tell. Thanks @adam-urbanczyk !

Copy link
Member

@lorenzncode lorenzncode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing with the PR branch and did not find any issue. Thanks @adam-urbanczyk !

@adam-urbanczyk adam-urbanczyk merged commit de71546 into master Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement selectors for cq.Shape

3 participants