Skip to content

Conversation

jdegenstein
Copy link
Contributor

_entitiesFrom seems to have an unnecessary call to TopTools_IndexedDataMapOfShapeListOfShape()

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #1439 (9181611) into master (7bc8c00) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 9181611 differs from pull request most recent head b8e5459. Consider uploading reports for the commit b8e5459 to get more accurate results

@@            Coverage Diff             @@
##           master    #1439      +/-   ##
==========================================
- Coverage   94.32%   94.32%   -0.01%     
==========================================
  Files          28       28              
  Lines        5813     5812       -1     
  Branches      994      994              
==========================================
- Hits         5483     5482       -1     
  Misses        198      198              
  Partials      132      132              
Files Coverage Δ
cadquery/occ_impl/shapes.py 93.24% <ø> (-0.01%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@adam-urbanczyk
Copy link
Member

Thanks @jdegenstein ! Small fix, merging.

@adam-urbanczyk adam-urbanczyk merged commit e85f766 into CadQuery:master Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants