Fix additional spaces in Python code blocks in tests #1861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct alignment is the 3 column, aligned to the `code-block` directive, not the 4 column. The extra space is not removed by the docutils parser, so the docs all had an extra space in them, which is very annoying for copy-pasting, especially into limited editors like the CQ-editor where you have to clean up every code sample before it works (otherwise you get IndentationError).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1861 +/- ##
=======================================
Coverage 95.66% 95.66%
=======================================
Files 28 28
Lines 7431 7431
Branches 1122 1122
=======================================
Hits 7109 7109
Misses 193 193
Partials 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
LGTM, thanks @spookylukey ! Formatting fix, so merging without reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct alignment for the content of these
code-blockdirectives is the 3rd column, (aligned to thecode-blocktext), not the 4th column.The extra space is not removed by the docutils parser, so the docs all have an extra space in them, which is very annoying for copy-pasting, especially into limited editors like the CQ-editor where you have to clean up every code sample before it works (otherwise you get IndentationError).
See, for example: https://cadquery.readthedocs.io/en/latest/quickstart.html#start-with-a-single-simple-plate
Some other whitespace errors with
imagedirective were also fixed.This is almost all rst files, one py file with some rst code was also fixed.