Make routes forward compatible #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the newest release is from the 3.x branch im proposing this here. Using said release (3.1.3) leads to deprecation warnings in CakePHP 4.3. Im aware that newer tags already have CakePHP 4.x conform routes however since this branch requires "cakephp/cakephp": "^4.0", in composer JSON i think this branch should also adhere to the new route structure.
ravage84
suggested changes
Nov 16, 2022
Co-authored-by: Marc Würth <ravage@bluewin.ch>
Co-authored-by: Marc Würth <ravage@bluewin.ch>
ravage84
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the newest release is from the 3.x branch im proposing this here. Using said release (3.1.3) leads to deprecation warnings in CakePHP 4.3. Im aware that newer tags already have CakePHP 4.x conform routes however since this branch requires "cakephp/cakephp": "^4.0", in composer JSON i think this branch should also adhere to the new route structure.