Regression on actual methods

[dereuromark]

With our last change, we now have issues with actually existing methods:

  Line   Controller/Admin/SupplierProductsController.php                        
 ------ ----------------------------------------------------------------------- 
  281    Method Cake\ORM\Table::findOrCreateBySku() invoked with 2 parameters,  
         1 required.                                                            
         🪪  arguments.count                                                    
  282    Access to an undefined property Cake\ORM\Query\SelectQuery::$id.       
         🪪  property.notFound                                                  
         💡  Learn more: https://phpstan.org/blog/solving-phpstan-access-to-und  
         efined-property       

    /**
     * @param string $sku
     * @param string $name
     *
     * @return \App\Model\Entity\Product
     */
    public function findOrCreateBySku(string $sku, string $name): Product
    {
        $product = $this->find()
            ->where(['sku' => $sku])
            ->first();
        if (!$product) {
            $product = $this->newEntity([
                'sku' => $sku,
                'name' => $name,
            ]);
            $product = $this->saveOrFail($product);
        }

        return $product;
    }

I think we need to check if the method actually exists and then skip our checks?

[dereuromark]

Hmm

For associations, we CANNOT check for native methods because we don't have access to the generic type parameter in a MethodsClassReflectionExtension. The extension should:

1. Check native methods only for direct Table classes
2. For associations, always assume magic methods (as it was originally) - limitation for people using those as actual methods..

This means the user's custom findOrCreateBySku method on VeryCustomize00009ArticlesTable cannot be properly detected when accessed through an association due to PHP Stan's architecture limitations.

=> The real issue is that PHPStan fundamentally cannot detect our native method when called through an association due to a architectural limitation.

[rochamarcelo]

Also I would expect to only handle findBy* methods. The findOrCreateBySku should be ignored.

[dereuromark]

True. I can fix that up.

PR should be fine now.