Fix up assoc bug in findBy magic.

[dereuromark]

I really wonder how this wasnt an issue so far, and I now run into this in my apps..

Resolves #51

The AssociationTableMixinClassReflectionExtension was handling magic findBy* methods correctly for direct Table classes, but when these
methods were called on Association properties, PHPStan would:

1. Check if the Association has the method via hasMethod()
2. Delegate to Table::hasMethod() without first checking for the findBy* pattern, returning false for magic methods
3. Try to get the method via getNativeMethod(), which throws an error since magic methods don't exist natively

Solution

Added checks in both hasMethod() and getMethod() in AssociationTableMixinClassReflectionExtension to properly handle findBy* methods on Association classes:

In hasMethod():

  // magic findBy* method on Association
  if (preg_match('/^find(?:\w+)?By/', $methodName) > 0) {
      return true;
  }

In getMethod():

  // magic findBy* method on Association
  if ($classReflection->isSubclassOf(Association::class) && preg_match('/^find(?:\w+)?By/', $methodName) > 0) {
      return new TableFindByPropertyMethodReflection($methodName, $this->getTableReflection());
  }

[rochamarcelo]

Does it happen only with latest CakePHP version?

I wonder if this is related to CakePHP, annotation or something else.

[dereuromark]

No idea
I just updated a project and ran into it.

The combine PR contains fix and enhancement

[rochamarcelo]

As reference it worked before because we had \App\Model\Table\UsersTable&\Cake\ORM\Association\HasMany annotations and now we use \Cake\ORM\Association\HasMany<\App\Model\Table\UsersTable>. That's why we didn't noticed the issue before.

Thank you.