UrlComparerTrait::_normalize throws

[nrother]

When upgrading to 3.1 and using the BootstrapNavbarHelper a MissingRouteException will be thrown from RouteCollection::parse, originating from BootstrapNavbarHelper::_normalize. The error message is "A route matching "/http://localhost/test" could not be found." (note the slash at front!)

This is likely due to the changes to RouteCollection::parse in CakePHP 3.4.

Test code:

$nav = $this->BootstrapNavbar;
echo $nav->beginMenu();
echo $nav->link('Test', ['controller' => 'Test', 'action' => 'index']);
echo $nav->end();

I'm using CakePHP 3.4 and Bootstrap Helpers 3.1.

A simple fix is to disable automatic link activation:

$this->BootstrapNavbar->config('autoActiveLink', false);

[Holt59]

Which version of CakePHP are you using?

Actually, I don't really understand the issue since /https://example.com/test is not a valid URL anyway, isn't it?

[nrother]

Sorry, my original bug report was really bad (I was kinda in a rush...). I updated the issue with more information.

[Holt59]

I will test this with a complete CakePHP installation when I get one, currently it seems to work in my test cases.

• Could you show me the relevant part of your config/routes.php?
• Do you use the latest CakePHP 3.4 version (released 2 days ago)?

[nrother]

This is from my routes.php (nothing special...)

$routes->connect('/', ['controller' => 'Pages', 'action' => 'display', 'home']);
$routes->connect('/register', ['controller' => 'Registrations', 'action' => 'selectProject']);
$routes->connect('/register/*', ['controller' => 'Registrations', 'action' => 'registerForProject']);
$routes->connect('/impressum', ['controller' => 'Pages', 'action' => 'display', 'imprint']);
$routes->connect('/confirmations/anmeldebestätigung_:id', ['controller' => 'Registrations', 'action' => 'getConfirmation'], ['pass' => ['id'], 'id' => '[0-9]+']);

$routes->connect('/admin', ['controller' => 'Pages', 'action' => 'display', 'prefix' => 'admin', 'home']);

Yes, I'm using the latest version (updated today).

Cake did change something in Route::parse, and for me it looks like for some reason a slash is prepended to the URL which confuses the following code. I also had some problems updating my own code...

[Holt59]

Should be fixed by 0f9d9bf, I have retro-added it to 3.1.0... This may still have issue with strange URLs, but should work pretty well for "standard" urls.

[nrother]

Yes, it works now.

Please note that composer hasn't noticed the retro-added commit, I had to remove and reinstall the package to make it see the update.

[nrother]

Ok, the fix did not completely resolve the issue, now every link is marked as active 😄 Maybe _normalize() is confused when the URL contains prefixes and/or is not in the base directory?

Example:

//Before normalize:
$lhs = '/chell/admin/rights';
$rhs = '/chell/admin/users/edit/1';
//After _normalize():
$lhs = '/chell/admin/chell/admin';
$rhs = '/chell/admin/chell/admin';

The URLs are in the admin prefix and my app is running under localhost/chell.

[Holt59]

The problem is that Router::url('/chell/admin/rights') returns '/chell/chell/admin/rights... The Router class of CakePHP is such a mess to me, it is really hard to work with...

As a temporary fix, could you not simply pass URL without the chell prefix to the Navbar helper? Such as:

$this->navbar->link('...', ['controller' => 'rights', 'action' => 'index', 'admin' => true]);

[Holt59]

I tried a fix which is now available on dev-master, v3.1.0 and v3.1.2. I do not have a lot of time to work on a really strong set of tests, but I will try to strengthen the current ones when I have.