Skip to content

Reuse HtmlHelper::tag and allow for options to be passed to function,… #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2015
Merged

Reuse HtmlHelper::tag and allow for options to be passed to function,… #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/View/Helper/BootstrapHtmlHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,26 +49,32 @@ public function __construct (\Cake\View\View $view, array $config = []) {
* @param $icon Name of the icon.
*
**/
public function icon ($icon) {
return $this->_useFontAwesome ? $this->faIcon($icon) : $this->glIcon($icon);
public function icon ($icon, $options = array()) {
return $this->_useFontAwesome ? $this->faIcon($icon, $options) : $this->glIcon($icon, $options);
}

/**
* Create a font awesome icon.
*
* @param $icon Name of the icon.
*/
public function faIcon ($icon) {
return '<i class="fa fa-'.$icon.'"></i>' ;
public function faIcon ($icon, $options = array()) {
$options = $this->addClass($options, 'fa');
$options = $this->addClass($options, 'fa-'.$icon);

return $this->tag('i', '', $options);
}

/**
* Create a glyphicon icon.
*
* @param $icon Name of the icon.
*/
public function glIcon ($icon) {
return '<i class="glyphicon glyphicon-'.$icon.'"></i>';
public function glIcon ($icon, $options = array()) {
$options = $this->addClass($options, 'glyphicon');
$options = $this->addClass($options, 'glyphicon-'.$icon);

return $this->tag('i', '', $options);
}

/**
Expand Down