DM-6542: Prevent external viewer from popup blockers. #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Both review and test are done. Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket: https://jira.lsstcorp.org/browse/DM-6542
to test:
goto http://localhost:8080/firefly/demo/ffapi-highlevel-test.html
at top of page, click "test open". a new tab(external viewer) should popup.
cmd+t(open new tab), goto http://localhost:8080/firefly/demo/ffapi-highlevel-test.html
click "test again", external viewer's title will flash "Updated" to indicate content of that page has been updated.
switch over to external viewer tab to see another image plotted.
at no point in this test should you be prompted by the browser's popup blocker.