Skip to content

Conversation

@tgoldina
Copy link
Contributor

  • Added decimation options to XYPlot options panel when numpoints exceed decimation limit of 5000
  • Changed selected series to be on top of data series to speed up selection change in Firefox
  • Added legend to decimated plot
  • Updated syncCharts saga to ignore sort action when refetching table statistics and histogram data

@loitly
Copy link
Contributor

loitly commented Jun 17, 2016

  • clicking ‘ok’ on the options should show validation errors on required fields, i.e. X, Y. instead of doing nothing.
  • just an idea.. when it’s decimated, you cannot ‘select’ multiple points. Yet, there is no indication that is normal. so, instead of show/hide the icons, gray it out when it’s not applicable. and in the decimation case, you can specifically say that it’s not supported.
  • some code is modifying the table’s results after filtering. i’ve seen this when tbl_id is not removed from request when doing a new search. may not be xyplot problem. could be image.
  • xyPlot selected points is off. i plot ra/dec. sorted table by descending ra. zoom in plot on ra < 19.5. highlight a row where ra > 150.. nothing show(good). then selected the same row.. a green dot shows(bad).
  • when X/Y ratio is large.. plot overflow.. but, have no way to scroll.
    mouse drag to select an area. no way to unselect it. i assume a click will unselect it. but, it does not.
  • set x-bin and y-bin to 500, legend no longer show the color, only label.

}


// plot parameters change
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding simple comments like these in this function really helps. it was hard to read without it.

- show validatiopn error on empty x or y
- show that selection is not possible on decimated data (by producing message on click, matching image behavior)
- selected points should match the table
- show scroll bar on large X/Y ratio
- can not change legend symbol size, but do not display it if too big or small
Also added some help text in options
@loitly
Copy link
Contributor

loitly commented Jun 17, 2016

Looks good.

@tgoldina tgoldina merged commit 54002e4 into dev Jun 18, 2016
@tgoldina tgoldina deleted the DM-5763_deciopts branch June 18, 2016 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants