DM-4591: GWT conversion: System notifications #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private static final Logger.LoggerImpl LOG = Logger.getLogger(); | ||
| private static final String ALERTS_DIR = AppProperties.getProperty("alerts.dir", "/hydra/alerts/"); | ||
| private static final File alertDir = new File(ALERTS_DIR); | ||
| private static Alert alerts = new Alert(null, "", true);; |
Contributor
|
Looks good, though modifying the existing notice does not work. Test sequence: The updated message never shows up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket: https://jira.lsstcorp.org/browse/DM-4591
to test:
rebuild firefly. restart tomcat.
http://localhost:8080/firefly/
mkdir -p /hydra/alerts/
echo 'some message you want users to see' > /hydra/alerts/notice.txt
within 10 seconds, you should see the notice appears on the drop down menu.
remove the file, and it'll go away.