Firefly-810: Fixed mask not loading correctly when zooming #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change mask to use local data - Mask should be faster with smaller memory load, mask data compress to bits - Added transparency to the color palette of the color change dialog - Fixed: Firefly-819 (simple one line fix) - Fixed: Bias sliders not working in 3-color mode
gpdf
requested changes
Jul 1, 2021
Contributor
gpdf
left a comment
gpdf
left a comment
There was a problem hiding this comment.
Mask zooming fix works and performance is now really impressive! Thank you.
FIREFLY-819 HiPS-properties links are now valid, accessible URLs, but they appear to be the wrong ones for the corresponding rows in the HiPS table.
Contributor
Author
This is a second problem with the HiPS table. We can't fix it in this release. I made a ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-822 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefly-810: Fixed mask not loading correctly when zooming
Testing URL
https://fireflydev.ipac.caltech.edu/firefly-810-mask/firefly/
Testing Steps
Ticket(s)
https://jira.ipac.caltech.edu/browse/FIREFLY-810
https://jira.ipac.caltech.edu/browse/FIREFLY-819