-
Notifications
You must be signed in to change notification settings - Fork 16
FIREFLY-938: ZTF proprietary metadata is not returned in GUI #1189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I confirm, this works; I can see data from 2/20/2022. I had some trouble (error messages) when logging in, but I did finally successfully log in, and I can see those data. |
|
(and before logging in, i could not see those data) |
wmiipac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code make sense to me for each ibe query url pass the authentication credential.
Tested searches and download with the proprietary data, works well.
Thanks!
ejoliet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Looks good!
(Was the Deprecated ibe file uploader class meant for IBE multi position search or was for something else)
It was just an unnecessary layer of abstraction design element that's not used. I would've removed it. But, since this is a hot patch fix, I don't want to put too much changes into it. |
robyww
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I don't see any reason not to remove the deprecated files.
| * | ||
| * @author loi | ||
| * @version $Id: $ | ||
| * @deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this file is not used why not just removed it.
| * Implementing IbeFileUploader using HttpClient via MultiPartPostBuilder | ||
| * @author loi | ||
| * @version $Id: $ | ||
| * @deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this file is not used why not just removed it.
Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-938
Test: https://firefly-938-ztf-proprietary.irsakudev.ipac.caltech.edu/applications/ztf/
Should be fixed now. Follow ticket description to test.