Skip to content

Conversation

@loitly
Copy link
Contributor

@loitly loitly commented Feb 23, 2022

@loitly loitly requested review from ejoliet, robyww and wmiipac February 23, 2022 01:56
@loitly loitly self-assigned this Feb 23, 2022
@lrebull
Copy link
Contributor

lrebull commented Feb 23, 2022

I confirm, this works; I can see data from 2/20/2022. I had some trouble (error messages) when logging in, but I did finally successfully log in, and I can see those data.

@lrebull
Copy link
Contributor

lrebull commented Feb 23, 2022

(and before logging in, i could not see those data)

Copy link
Contributor

@wmiipac wmiipac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code make sense to me for each ibe query url pass the authentication credential.
Tested searches and download with the proprietary data, works well.
Thanks!

Copy link
Contributor

@ejoliet ejoliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good!

(Was the Deprecated ibe file uploader class meant for IBE multi position search or was for something else)

@loitly
Copy link
Contributor Author

loitly commented Feb 23, 2022

Tested. Looks good!

(Was the Deprecated ibe file uploader class meant for IBE multi position search or was for something else)

It was just an unnecessary layer of abstraction design element that's not used. I would've removed it. But, since this is a hot patch fix, I don't want to put too much changes into it.

Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't see any reason not to remove the deprecated files.

*
* @author loi
* @version $Id: $
* @deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this file is not used why not just removed it.

* Implementing IbeFileUploader using HttpClient via MultiPartPostBuilder
* @author loi
* @version $Id: $
* @deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this file is not used why not just removed it.

@robyww robyww added this to the 2021.4 milestone Feb 23, 2022
@robyww robyww added the bug label Feb 23, 2022
@loitly loitly merged commit 84535f7 into rc-2021.4 Feb 23, 2022
@loitly loitly deleted the FIREFLY-938_ztf_proprietary branch February 23, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants