DM-7055: fix miscellaneous table issues #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
loitly
commented
Aug 1, 2016
loitly
commented
- disable sorting when content is html
- table options: auto-adjust all column width based on content
- table refractoring..
- renamed a few actions to better reflect what it's doing.
- added TABLE_FILTER
- document sequence of actions where applicable.
- update build script to skip buildClient when possible.
- disable sorting when content is html
- table options: auto-adjust all column width based on content
- table refractoring..
- renamed a few actions to better reflect what it's doing.
- added TABLE_FILTER
- document sequence of actions where applicable.
- update build script to skip buildClient when possible.
Contributor
|
I think 5th issue (Catalog overlay should not use table id in drawing layer description. (See the attached screenshot.) It should be using MetaConst.CATALOG_OVERLAY_TYPE attribute value) was added after your last commit, and you did not have chance to fix it. |
| case TABLE_LOADED: | ||
| if (!getTableInGroup(tbl_id)) continue; | ||
| decimatedTables[tbl_id]= null; | ||
| displayedTableId = updateCoverage(tbl_id, viewerId, decimatedTables, options); |
Contributor
There was a problem hiding this comment.
Should we update coverage image on invokedBy === TablesCntlr.TABLE_SORT? Probably not. Since all CoverageWatcher is doing is collecting points to calculate the parameters of the coverage image.
Contributor
Author
There was a problem hiding this comment.
yep.. added logic to skip updateCoverage when table is reloaded due to sorting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.