DM-7271: table enhancements #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not apply default data format - introduce optional display format - add "AUTO" and "NONE" as format keywords. - for fits table, set display format to "%.9g" for double type. - add support for TDISPn fits table header - remove condition so temp files will not get written into source directory
loitly
force-pushed
the
DM-7271_table_disp_format
branch
from
a971cc5 to
f707022
Compare
| dt.getFormatInfo().setWidth(Arrays.stream(new int[]{ | ||
| dt.getKeyName().length(), | ||
| dt.getDataUnit().length(), | ||
| dt.getTypeDesc().length()}).max().getAsInt()); |
Contributor
There was a problem hiding this comment.
Can data unit or type desc be null?
Contributor
|
Review complete. Looks good. As we talked, it would be nice to save display format in decimated data too. Currently, when catalog is loaded from a FITS table, XYPlot points have higher precision than table data, which can result in a gap between the displayed point and the highlight when the resolution is high or there is only one point. Later we might want to carry server-side precision to the client and use display format only to format. |
Contributor
|
Review complete. Works as expected for the 3 table types I've tested: IRAS catalog, FITS binary, uploaded IPAC table without type info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DM-7271: table enhancements
When reading fits table, set display format to "%.9g" for double if TDISPn is not given.