DM-7317 Log scale doesn't work with sample table attached #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tgoldina
commented
Aug 25, 2016
tgoldina
commented
- Fixed log scale issue (when minimum value is close to 0
- Added more support for error conditions (still no way to catch errors in render)
- More validation for log scale in XYOptions
- Trey's changes for MULTI_VALUE_CHANGE - field reducer is now called once on form submit
| if (!isCatalog) { | ||
| const numericCols = getNumericCols(tableData.columns); | ||
| if (numericCols.length > 2) { | ||
| if (numericCols.length >= 2) { |
Contributor
There was a problem hiding this comment.
That's a good fix too! Thanks!
Contributor
|
Works ok to me. Review done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.