TMP: temporarily comment out list_collection calls #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
All green, so I go ahead with this. |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
TMP: temporarily comment out list_collection calls eca4a4b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix/workaround the timeout issues we run into during the HTML builds. The reason is that astroquery is running a sync TAP query under the hood and the query is currently not cached on the server side.
We do fix this upstream in two, redundant ways:
list_collections(see ENH: change Irsa's list_collection to use async_tap astropy/astroquery#3366)In the meantime I remove these code cells from the notebooks so the rendered HTMLs can be updated.