ENH: adding conditional to test execution #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
added
infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is no need to run the test matrix for PRs like #25
I would even go as far as there is no need to execute the notebooks for such PRs in circleCI, however it sounds a bit hacky and ugly how such a workaround can be added there (as I see there isn't an easy way to get access to the github labels to write such a conditional there just outstanding feature requests such as https://ideas.circleci.com/cloud-feature-requests/p/provide-github-labels-for-filtering, and even then we need to sed nb_execution_mode to be off in the tox config before it is being picked up by the runner...)