-
Notifications
You must be signed in to change notification settings - Fork 201
Add LNbits payment processor #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 4149139594Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Fixed the broken migration -- it should now work. Also merged all changes into one commit. |
also adds two utility functions and ensures the SECRET environment variable is set.
|
Hey @Semisol thanks for the PR, looks pretty good, I just added some comments/recommendations to bring it to the finish line and merge! |
|
tested, works |
|
🎉 This PR is included in version 1.22.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
* feat: add lnbits payment processor * fix: add lnbits error logging and add lnbits config * feat: use HMAC instead of IP whitelist for LNbits also adds two utility functions and ensures the SECRET environment variable is set. * refactor: remove unnecessary comment * fix(pay-to-relay/lnbits): compare by msat scaled amount * fix: scale balance addition with invoice unit on confirm_invoice
Description
Adds the LNbits payment processor. Also includes:
BigInt->biginton files that I have touchedRelated Issue
Closes #163
Motivation and Context
Allowing users to receive pay to relay payments via alternative methods/to their own node.
How Has This Been Tested?
Tested on production with atlas.nostr.land. Would prefer someone else tests this too.
Types of changes
Checklist:
note: I couldn't find any tests related to pay to relay