Skip to content

don't abort encoding if capurer stop fails #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
Merged

don't abort encoding if capurer stop fails #1223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ff2a96
don't abort encoding if capurer stop fails
Brendonovich Oct 17, 2025
432af2e
separate capture-video task
Brendonovich Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions crates/recording/src/output_pipeline/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,13 +405,26 @@ fn spawn_video_encoder<TMutex: VideoMuxer<VideoFrame = TVideo::Frame>, TVideo: V
muxer: Arc<Mutex<TMutex>>,
timestamps: Timestamps,
) {
setup_ctx.tasks().spawn("capture-video", {
let stop_token = stop_token.clone();
async move {
video_source.start().await?;

stop_token.cancelled().await;

if let Err(e) = video_source.stop().await {
error!("Video source stop failed: {e:#}");
};

Ok(())
}
});

setup_ctx.tasks().spawn("mux-video", async move {
use futures::StreamExt;

let mut first_tx = Some(first_tx);

video_source.start().await?;

stop_token
.run_until_cancelled(async {
while let Some(frame) = video_rx.next().await {
Expand All @@ -432,8 +445,6 @@ fn spawn_video_encoder<TMutex: VideoMuxer<VideoFrame = TVideo::Frame>, TVideo: V
})
.await;

video_source.stop().await.context("video_source_stop")?;

muxer.lock().await.stop();

Ok(())
Expand Down
Loading